Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #12311 - Fix issue with failed initialization of rack openid middleware. #2854

Closed
wants to merge 1 commit into from
Closed

Fixes #12311 - Fix issue with failed initialization of rack openid middleware. #2854

wants to merge 1 commit into from

Conversation

cpeters
Copy link
Contributor

@cpeters cpeters commented Oct 21, 2015

This fix is for rails4 but is backwards compatible with rails3

When placed in a rails initializer the rack middleware fails to
load, throwing a can't modify frozen array error. Moving the
initialization to the application config resolves this issue.

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • fba91a3 must be in the format fixes #redmine_number - brief description.

If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project.

More guidelines are available on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@dLobatog
Copy link
Member

@cpeters Thanks, this is ready IMO. Just create an issue in redmine as @theforeman-bot said please 😄 and fix the commit title.

Thanks again!

@dLobatog
Copy link
Member

@cpeters ping?

@cpeters
Copy link
Contributor Author

cpeters commented Oct 26, 2015

@dLobatog I'll take care of this today. Thanks.

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 1c76274d9ad927c7dd6b353604e34af9a0ad7625 must be in the format fixes #redmine_number - brief description.

If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project.

More guidelines are available on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

…ddleware.

This fix is for rails4 but is backwards compatible with rails3

When placed in a rails initializer the rack middleware fails to
load, throwing a can't modify frozen array error. Moving the
initialization to the application config resolves this issue.
@cpeters cpeters changed the title Fix issue with failed initialization of rack openid middleware. Fixes #12311 - Fix issue with failed initialization of rack openid middleware. Oct 26, 2015
@cpeters
Copy link
Contributor Author

cpeters commented Oct 26, 2015

@dLobatog I'm not able to edit the status or PR link in the redmine issue.
http://projects.theforeman.org/issues/12311

@dLobatog
Copy link
Member

Merged as 0a66fee, thanks @cpeters!

@dLobatog dLobatog closed this Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants