Fixes #13074 - sprockets-rails should be in Gemfile #3047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,6 @@ | |||
| gem 'autoprefixer-rails', '~> 5.2' | |||
| gem 'sprockets', '~> 3' | |||
There was a problem hiding this comment.
This is also a runtime dep, should it be moved to Gemfile also?
(See your PR description!)
There was a problem hiding this comment.
Thought I moved both, thanks!
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
| @@ -39,6 +39,8 @@ end | |||
| gem 'activerecord-session_store', '~> 0.1.1' | |||
| gem 'rails-observers', '~> 0.1' | |||
| gem 'protected_attributes', '~> 1.1.1' | |||
| gem 'sprockets', '~> 3' | |||
| gem 'sprockets-rails', '~> 2.3.3', '< 3' | |||
There was a problem hiding this comment.
Looks like a typo from aa50ab1, but this should be >= and not ~> else it'll never get beyond 2.3.x.
dependency out of the Gemfile and into assets.rb. sprockets-rails is a runtime dependency and so should stay in Gemfile. #12977 was a runtime error in production. The sprockets gem is also a runtime dependency, so should be in Gemfile rather than assets.rb.
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
Updated to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependency out of the Gemfile and into assets.rb. sprockets-rails is a
runtime dependency and so should stay in Gemfile. #12977 was a runtime
error in production.
The sprockets gem is also a runtime dependency, so should be in Gemfile
rather than assets.rb.