Fixes #13165 - select2 fields border radius should be square #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With patternfly border-radius are supposed to be 0px. However some of them are not, even if we override it, because the select2 stylesheet coming from the gem has set '!important' to some CSS rules. Before: http://i.imgur.com/YSVys3l.png How it should look: http://i.imgur.com/Kd6FM64.png
|
Is there any trick to reproducing this? I can't do so on the New Host form in either Chrome or Firefox, the borders are all square. I don't see any border-radius entries in select2-rails version 3.5.9.3 with !important, do you have an older version perhaps? |
|
They are square for me as well |
|
Closing - I guess I was using an older version of select2-rails or something similar, in any case they're square now indeed. Thanks @domcleal and @shlomizadok for taking the time to try it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With patternfly border-radius are supposed to be 0px. However some of
them are not, even if we override it, because the select2 stylesheet
coming from the gem has set '!important' to some CSS rules.
Before:
How it should look: