-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #13594 - Pin parser gem to 2.3 #3164
Conversation
Is this fixed in master upstream, or reported? Which release are you intending to pin to exactly? 2.3.0.0? |
2.3.0.2 is good too, the issue is that they tried to introduce a cache for line reading in parser on 2.3.0.3 - whitequark/parser@1779727 but the hash is not initialized under some conditions, hence it fails. |
Yes, pinning to a more specific version would be better (.2 preferably), it's slightly unclear to me what |
ce5c787
to
90fdd0e
Compare
Done. Thanks for the input. |
whitequark/parser#271 has been filed now, will merge if green, thanks @shlomizadok |
Rubocop is green, don't think we need to wait for tests to finish as this gem is exclusively used by Rubocop. |
Merged as 9dfe1fe, thanks @shlomizadok! |
No description provided.