Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #13594 - Pin parser gem to 2.3 #3164

Closed
wants to merge 1 commit into from

Conversation

shlomizadok
Copy link
Member

No description provided.

@domcleal
Copy link
Contributor

domcleal commented Feb 8, 2016

Is this fixed in master upstream, or reported?

Which release are you intending to pin to exactly? 2.3.0.0?

@shlomizadok
Copy link
Member Author

@dLobatog found the issue on parser and is about to submit a patch.

Rubocop on test passes, would you like me to pin it to 2.3.0.0 specifically?

@dLobatog
Copy link
Member

dLobatog commented Feb 8, 2016

2.3.0.2 is good too, the issue is that they tried to introduce a cache for line reading in parser on 2.3.0.3 - whitequark/parser@1779727 but the hash is not initialized under some conditions, hence it fails.

@domcleal
Copy link
Contributor

domcleal commented Feb 8, 2016

Yes, pinning to a more specific version would be better (.2 preferably), it's slightly unclear to me what 2.3 means otherwise.

@shlomizadok
Copy link
Member Author

Done. Thanks for the input.

@dLobatog
Copy link
Member

dLobatog commented Feb 8, 2016

whitequark/parser#271 has been filed now, will merge if green, thanks @shlomizadok

@dLobatog
Copy link
Member

dLobatog commented Feb 8, 2016

Rubocop is green, don't think we need to wait for tests to finish as this gem is exclusively used by Rubocop.

@dLobatog
Copy link
Member

dLobatog commented Feb 8, 2016

Merged as 9dfe1fe, thanks @shlomizadok!

@dLobatog dLobatog closed this Feb 8, 2016
@dLobatog
Copy link
Member

dLobatog commented Feb 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants