Fixes #13753 - adding statistics on compute_resources usage #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All models etc. referenced within the Rails environment startup, including in initialisers should load without making any reference to the database. This ensures when running `rake test` without a test DB set up already that the Rails env can be loaded first by Rails before it prepares the test DB from db/schema.rb (itself created by a db:migrate in dev/prod envs). The table_name for Ptable needed to be overridden, matching ProvisioningTemplate as it defaulted to 'ptables' rather than 'templates' when the `attribute_names` call was removed from validate_inclusion_in_families. References to attribute_names in API controller wrapping overrides were replaced by reusing the protected_attribute lists, which don't use the database and are also more consistent than the existing lists.
We already use json 1.8, this workaround is no longer needed.
JSON is included in Ruby stdlib >= 1.9
Rubocop can enforce what timezone to store in the database , so we can ensure everything is stored using UTC and we don't miss these things in code reviews. When objects are displayed, they must use the time provided by set_timezone in the controller. This is particularly relevant for Trends, Puppet graphs, etc... to ensure they are stored always properly
The status colors are a bit off from the colors suggested in the palette. https://www.patternfly.org/styles/color-palette/
apparently, the PO generator treats underscore as something important, it assumes it's the GetText underscore method, thus, breaking things in a spactacular way. removing it solves it.
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project. More guidelines are available on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
|
@jhutar Please rebase your branch against the current develop branch. |
|
I can just put the line in my patch. Or just wait once my work is merged, then rebase on top of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on Lukas's branch lzap:debug-db-13703 and that is being reviewed in #3184
Because I hope to his soonest possible release (1.11?) I wanted to ask for a review now, while only relevant commit is e919755.
I have not tested on MySQL, so I would appreciate help here.
Thank you very much in advance for a review.