Fixes #13757 - spilt layout helper into two helpers #3202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amirfefer Thanks, notice tests are failing |
dLobatog
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
[test] |
|
@amirfefer there are a few methods in |
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
Layout helper is too large, all the forms logic moved to form helper
|
@tbrisker |
| end | ||
| end | ||
|
|
||
| def addClass(options = {}, new_class = '') |
There was a problem hiding this comment.
This should stay in layout helper
There was a problem hiding this comment.
Ok, nevermind, looks like this is only used in the form helper.
|
@amirfefer Looks good, just one function you accidentally moved to |
|
Merged as 3952cb5, thanks @amirfefer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layout helper is too large, all the forms logic moved to form helper