-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #13757 - spilt layout helper into two helpers #3202
Conversation
@amirfefer Thanks, notice tests are failing |
[test] |
@amirfefer there are a few methods in |
Layout helper is too large, all the forms logic moved to form helper
@tbrisker |
end | ||
end | ||
|
||
def addClass(options = {}, new_class = '') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should stay in layout helper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, nevermind, looks like this is only used in the form helper.
@amirfefer Looks good, just one function you accidentally moved to |
Merged as 3952cb5, thanks @amirfefer! |
Layout helper is too large, all the forms logic moved to form helper