Fixes #13232 - Reword 'ACK' buttons texts #3208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +15,7 @@ | |||
| </div> | |||
| </div> | |||
| <div class="modal-footer"> | |||
| <button type="button" class="btn btn-default" data-dismiss="modal"><%= _('ACK') %></button> | |||
| <button type="button" class="btn btn-default" data-dismiss="modal"><%= _('OK') %></button> | |||
There was a problem hiding this comment.
Why not Overwrite too? Anyway, I created a conflict to force this show up and it's not working after I click on 'OK' (unrelated to this PR I know)
There was a problem hiding this comment.
Because afaik, it will not create an overwrite, as it is an error and not a conflict - It will ask you to fix the errors (also implied with the modal message: Please correct the error(s) below and submit your changes again.
Whereas, in conflict you may overwrite it, hence the change in the button text. (also note the modal message in conflict is different)
|
Merged as 6fdd5bf, thanks @shlomizadok! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.