fixes #13244 - update Rails to 4.2.6 #3294
Conversation
- Add responders gem to support class-level respond_to usage
- http://edgeguides.rubyonrails.org/4_2_release_notes.html#respond-with-class-level-respond-to
- Replace foreigner with native Rails 4.2 FK support
- uses a patch from Rails 5 to support Foreigner's
`foreign_key_exists?` helper for full compatibility
- `foreign_keys` should be avoided in favour of the higher level
methods as it throws a NotImplementedError on sqlite3
- Update DB adapter versions to match ActiveRecord
- Enable exceptions from after_commit handlers to detect more errors
- Change deprecated application config settings
- Remove test:lib chaining on rake test task
- 4.2 runs lib tasks automatically now, as test:run is redefined
to all _test files within test/ rather than units+functionals.
The task is still needed for the jenkins:* tasks.
- Fix deprecation of mailer #deliver method, change to #deliver_now
- Change CSRF test to use generated, not static tokens
- 4.2 changes CSRF tokens to be different on every request and
validated against the session, so use its generator to test the
controller behaviour instead of hardcoding tokens.
| @@ -57,4 +57,7 @@ | |||
|
|
|||
| # Enable automatic creation/migration of the test DB when running tests | |||
| config.active_record.maintain_test_schema = true | |||
|
|
|||
| # Maintain standard order of running tests in case of leaking changes | |||
| config.active_support.test_order = :sorted | |||
There was a problem hiding this comment.
Why? This can make our tests order dependant
There was a problem hiding this comment.
I ran a few tests with it set to random and I'm sure they already are order dependent (since :sorted is the current Rails/develop behaviour), and we're not alone.
I think the affected test cases are:
- Api::V2::OperatingsystemsControllerTest
- Api::V2::OsDefaultTemplatesControllerTest
- Api::V2::OverrideValuesControllerTest
- Api::V2::ParametersControllerTest
- Api::V2::PuppetclassesControllerTest
- Api::V2::ReportsControllerTest
- Api::V2::RolesControllerTest
- Api::V2::SmartClassParametersControllerTest
- Api::V2::SmartProxiesControllerTest
- Api::V2::SmartVariablesControllerTest
- Api::V2::SubnetsControllerTest
- Api::V2::TasksControllerTest
- Api::V2::TemplateCombinationsControllerTest
- SeedsTest
Jenkins runs:
- http://ci.theforeman.org/job/test_develop_pr_core/8473/
- http://ci.theforeman.org/job/test_develop_pr_core/8474/
- http://ci.theforeman.org/job/test_develop_pr_core/8475/
I'll take a closer look at each test soon and see if I can address the root causes in develop, then when it's stable we can flip this to random on this branch. Is that OK?
There was a problem hiding this comment.
I started tracking fixes under http://projects.theforeman.org/issues/14155.
There was a problem hiding this comment.
Yeah that makes sense, I thought they were running in random order using the --seed param until now
|
@domcleal Left a couple of comments I didn't understand - other than that 👍 , thanks for doing this |
dLobatog
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
|
LGTM, Foreman Discovery 5.0.2/develop works fine. All tests are green. |
domcleal
added
Needs re-review
Waiting on contributor
and removed
Waiting on contributor
Needs re-review
labels
|
The rails42 branch/commits have now been merged to develop as 85a9714. |
foreign_key_exists?helper for full compatibilityforeign_keysshould be avoided in favour of the higher levelmethods as it throws a NotImplementedError on sqlite3
to all _test files within test/ rather than units+functionals.
The task is still needed for the jenkins:* tasks.
validated against the session, so use its generator to test the
controller behaviour instead of hardcoding tokens.
Please note this is against the rails42 branch, not develop, per https://groups.google.com/forum/#!topic/foreman-dev/6ANhWVGDzNA. Katello tests will fail, you'll need to ignore them on this branch until it's fixed.