Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #14166 - Host facet attributes handling updated #3309

Closed
wants to merge 1 commit into from
Closed

Fixes #14166 - Host facet attributes handling updated #3309

wants to merge 1 commit into from

Conversation

parthaa
Copy link
Contributor

@parthaa parthaa commented Mar 11, 2016

Basically added code to include handling of host facets in hosts where
no form attributes belonging to that facet are set.

@parthaa
Copy link
Contributor Author

parthaa commented Mar 14, 2016

[test]

@dLobatog
Copy link
Member

@parthaa Thanks, please:

  • Use 1.8 hash syntax (=>) as the rest of the code base
  • Add some tests for this

@parthaa
Fixes #14166 - Host facet attributes handling updated
3cb9b1e 
Basically added code to include handling of host facets in hosts where
no form attributes belonging to that facet are set.
@parthaa
Copy link
Contributor Author

parthaa commented Mar 22, 2016

@dLobatog updated. Thanks for the suggestions 👍

@dLobatog
Copy link
Member

Merged as 5d64eef, thanks @parthaa!

@dLobatog dLobatog closed this Mar 28, 2016
@snyk-bot snyk-bot mentioned this pull request Dec 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs re-review Needs testing
Projects
None yet
Milestone
No milestone
3 participants
@parthaa @dLobatog @theforeman-bot