Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14173 - Puppet Summary Report host listing should be alphabetically sorted. #3315

Closed
wants to merge 1 commit into from

Conversation

ranjan
Copy link
Contributor

@ranjan ranjan commented Mar 14, 2016

No description provided.

@shlomizadok
Copy link
Member

Should they be sorted by created_at date?

@ranjan
Copy link
Contributor Author

ranjan commented Mar 14, 2016

It should be sorted by hostname.

@domcleal
Copy link
Contributor

[test]

@dLobatog
Copy link
Member

@ranjan Thanks! Please add a test for this. About the ordering, I think that's highly subjective, I'd prefer them to be ordered by last report - why do you say it should be sorted by hostname?

@domcleal
Copy link
Contributor

@dLobatog note that the active list already is sorted by hostname (@host/host_data)

@ranjan
Copy link
Contributor Author

ranjan commented Apr 7, 2016

[test] failure looks unrelated to the change

@dLobatog
Copy link
Member

dLobatog commented Apr 8, 2016

Merged as cce6720, thanks @ranjan!

@dLobatog dLobatog closed this Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants