Fixes #15053 - Select AR order values for uniq
#3529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akofink
changed the title
Bug 15053 occurs when we call `uniq` on an ActiveRecord::Relation that orders on some number of columns without explicitly selecting those columns. This bug is found using a PostgreSQL database with the DB error: "SELECT DISTINCT, ORDER BY expressions must appear in select list" - Add a test that replicates bug 15053 - Select the ActiveRecord::Relation `order_values` when using `uniq` to satisfy the `select distinct` PostgreSQL requirement
akofink
changed the title
order values for uniq
|
@akofink Thanks for the patch! I've just tried to reproduce the same steps:
I could not reproduce the issue, plus, the test in this PR passes w/o the fix included so I don't think it's testing any bug. Mind to dig a bit deeper into what's actually causing the StatementInvalid problem you saw? Thanks! |
dLobatog
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
|
The Redmine ticket also must be moved into the Foreman project if it is a bug in Foreman (subject to above comments). |
|
@dLobatog Hm... I don't seem to be able to replicate it anymore either. Perhaps it was fixed since Friday? I'll go ahead and close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 15053 occurs when we call
uniqon an ActiveRecord::Relation thatorders on some number of columns without explicitly selecting those
columns. This bug is found using a PostgreSQL database with the DB
error: "SELECT DISTINCT, ORDER BY expressions must appear in select
list"