Fixes #16389 - enable taxable object creation in specific context #3801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| org = FactoryGirl.create :organization | ||
| FactoryGirl.create(:domain, :organizations => [ org ]) | ||
| original_org, Organization.current = Organization.current, org | ||
| $debug = true |
There was a problem hiding this comment.
Do not introduce global variables.
|
[test] |
|
APJ, if there was emoji for :respect: I would use one :) |
| tax_ids = taxable_ids | ||
| # we need to generate part of SQL query as a string, otherwise the default scope would set id on each | ||
| # new instance and the same taxable_id on taxable_taxonomy objects | ||
| scope = scope.where("#{self.table_name}.id IN (#{tax_ids.join(',')})", ) if tax_ids |
|
@iNecas one more change was needed, we have to be explicit about the table name and we can't escape the values inside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.