Fixes #15285 - save browser timezone in User

[shlomizadok]

Not sure about this pull request:
Currently when a user chooses "Browser timezone" it is set to nil in the User model. And because it is empty we set it to the cookie's timezone.
The change in this pull request will enforce that the cookie's timezone will be saved for the user.

Would love to hear your comments

[dLobatog]

@shlomizadok Thanks for the effort but app/controllers/concerns/application_shared.rb does the job already, why do you want to save it? It's set on every request and it allows us to not have to take care of yet another property on user. You wrote that code so I guess you have reasons to want to save it..?

[shlomizadok]

I am conflicted to be honest.
On one hand, as you have said: We don't really need it application_shared.rb is handling it correctly.
On the other hand, if a user picks the "Browser timezone", it is never really saved anywhere.

I'll let you decide 😄 - I'm good either way

[dLobatog]

I prefer to close it - it means zero extra work & risk for a feature that already works pretty well (which you yourself did 😄 )