fixes #2151 - use DN environment variable instead of CN #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nginx is unable to pass bits of the X.509 subject, only the entire DN, so support that as a lowest common denominator.
|
merged - thanks |
cfouant
pushed a commit
to cfouant/foreman
that referenced
this pull request
Dec 18, 2018
Group should be foreman-proxy-content not foreman_proxy_content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nginx is unable to pass bits of the X.509 subject, only the entire DN, so
support that as a lowest common denominator.
I was going to change the rDNS scheme as well, but decided that I'll mention it in my e-mail to foreman-users to get feedback (will send as soon as the installer PR's merged).