Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #16819 - rebuild tftp with template kinds #3929

Merged
merged 1 commit into from
Oct 13, 2016
Merged

fixes #16819 - rebuild tftp with template kinds #3929

merged 1 commit into from
Oct 13, 2016

Conversation

timogoebel
Copy link
Member

No description provided.

domcleal
domcleal suggested changes Oct 10, 2016
View reviewed changes
app/models/concerns/orchestration/tftp.rb
setTFTP
host.operatingsystem.template_kinds.each do |kind|
setTFTP(kind)
end
rescue => e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this inside the template_kinds loop? Have a look at Orchestration::DNS for a similar example, where the rebuild method always tries to rebuild as much as possible, even if one fails, but then returns false on failure.

@lzap
Copy link
Member

lzap commented Oct 10, 2016

Ah, sorry about this one. This is when tests won't help much, compiler would do it.

@timogoebel
Copy link
Member Author

@lzap: No worries. ;-)

@domcleal : Pushed the latest changes that should address your comment.

@domcleal domcleal merged commit 25f058c into theforeman:develop Oct 13, 2016
@domcleal
Copy link
Contributor

Merged, thanks @timogoebel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domcleal domcleal domcleal approved these changes

Assignees
No one assigned
Labels
Needs re-review Needs testing
Projects
None yet
Milestone
No milestone
4 participants
@timogoebel @lzap @domcleal @theforeman-bot