fixes #17474 Postgres restore task now cleans the db prior to import. #4046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohadlevy
force-pushed
the
clean-on-restore
branch
from
8bbd642
to
76b250d
Compare
theforeman-bot
added
Needs testing
Waiting on contributor
and removed
Waiting on contributor
labels
when using postgres as a database, and restoring and existing db dump, clean the target database prior to restore. this allow the usage case when installing a new server, running foreman-installer and then restoring the database.
ohadlevy
force-pushed
the
clean-on-restore
branch
from
76b250d
to
0d2debd
Compare
|
When I wrote the task, I did not run foreman installer, I was under the assumption that one would restore the db manually and not rely on foreman-installer to create it first. This will fix it - so 👍 It's dangerous in case you have a existing db and you wipe it by accident with this, so I'll add a confirmation step on a separate PR. Thanks @ohadlevy |
|
Today I spent some time with incorrect restore, I highly suggest to add |
|
Send a new pr?
…On Dec 9, 2016 4:27 PM, "Lukáš Zapletal" ***@***.***> wrote:
Today I spent some time with incorrect restore, I highly suggest to add -e
(exit on error) there as well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4046 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABOxymzjg1TDXlE0Hkdn-rCXXkR4KFmks5rGWU7gaJpZM4K7qGK>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.