Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #16422 - Foreman API throws ruby exception with ovirt network API #4060

Merged
merged 2 commits into from
Nov 28, 2016
Merged

Fixes #16422 - Foreman API throws ruby exception with ovirt network API #4060

merged 2 commits into from
Nov 28, 2016

Conversation

jkroepke
Copy link
Contributor

@theforeman-bot
Copy link
Member

Can an existing organization member please verify this patch?

2 similar comments
@theforeman-bot
Copy link
Member

Can an existing organization member please verify this patch?

@theforeman-bot
Copy link
Member

Can an existing organization member please verify this patch?

@mention-bot
Copy link

@jkroepke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ShimShtein, @isratrade and @dLobatog to be potential reviewers.

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for 8012e3c exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

houndci-bot
houndci-bot reviewed Nov 27, 2016
View reviewed changes
app/controllers/api/base_controller.rb
@@ -321,7 +321,7 @@ def parent_resource_details
parent_class
end

return nil if parent_name.nil?
return nil if parent_name.nil? or parent_class.nil?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use || instead of or.

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for 8012e3c exceeds 65 characters
  • 7e4e3a5 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@mmoll
Copy link
Contributor

mmoll commented Nov 27, 2016

ok to test

@timogoebel
Copy link
Member

[test foreman]

@dLobatog dLobatog merged commit 9fb9397 into theforeman:develop Nov 28, 2016
@dLobatog
Copy link
Member

Passing a 'nil' resource_class to the scope_for method will always result in a 500 as you cannot call .where on nil - merging 😄 Thanks @jkroepke & @mmoll @timogoebel

@jkroepke jkroepke deleted the patch-1 branch November 28, 2016 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees
No one assigned
Labels
Needs testing Not yet reviewed Waiting on contributor
Projects
None yet
Milestone
No milestone
7 participants
@jkroepke @theforeman-bot @mention-bot @mmoll @timogoebel @dLobatog @houndci-bot