Fixes #17666 - prevent migration failures on counter cache #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tbrisker, thanks for your PR! By analyzing the history of the files in this pull request, we identified @stbenjam, @ShimShtein and @shlomizadok to be potential reviewers. |
Removal of counter cache causes migrations relying on the `reset_counters` method to fail. The migrations are changed to not update the counters (which are now removed anyways).
ohadlevy
reviewed
Dec 13, 2016
|
@ohadlevy the reason this was hit in the BZ is that satellite 6.2.5 includes the counter cache removal. This will however hit foreman users as well if attempting to upgrade several releases at once, since the |
|
@tbrisker so if a user goes from Foreman 1.7 -> 1.13 they most likely will hit this right? |
|
@mccun934 even 1.10->1.13, the last of these migrations was only included in 1.11 |
|
Thanks, this indeed helps to mitigate the upgrade hop issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of counter cache causes migrations relying on the
reset_countersmethod to fail. The migrations are changes to notupdate the counters (which are now removed anyways).