Fixes #17842 - Adds 'type = compute_resource' to Audit search #4131
Conversation
|
@shlomizadok, thanks for your PR! By analyzing the history of the files in this pull request, we identified @amirfefer, @isratrade and @orrabin to be potential reviewers. |
|
@shlomizadok How about adding all the missing types? |
|
|
||
| test "search for type=compute_resource in audit" do | ||
| FactoryGirl.create(:ec2_cr) | ||
| refute_empty Audit.search_for("type = compute_resource") |
There was a problem hiding this comment.
assert_empty before the creation please to make sure that it isn't empty because the creation added an entry.
There was a problem hiding this comment.
I do not care if it is empty... I just want to ensure I have at least one when I search.
The purpose of this test is to ensure I can seach Audit by type=compute_resource
There was a problem hiding this comment.
also would be nice to show that you search for different compute resource types ?(e.g. that STI works correctly).
|
@tbrisker - each type at a time 😄 |
shlomizadok
force-pushed
the
fix_17842
branch
from
00eb0c8
to
b62d82d
Compare
shlomizadok
force-pushed
the
fix_17842
branch
from
b62d82d
to
e4e751e
Compare
No description provided.