Fixes #17870 - Empty boolean matcher should not turn into false #4144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orrabin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ShimShtein, @isratrade and @stbenjam to be potential reviewers. |
tbrisker
suggested changes
Dec 29, 2016
| @@ -44,6 +44,7 @@ def value_before_type_cast | |||
| end | |||
|
|
|||
| def validate_value | |||
| validate_and_cast_value | |||
There was a problem hiding this comment.
since this no longer runs in a callback, it doesn't need to return true/false, which means it can be greatly simplified.
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
tbrisker
approved these changes
Dec 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.