Fixes #17998 - Only print LDAP bind status if available #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ldap logger tries to call payload[:bind].status but it might not be defined if the bind goes wrong in some LDAP sources. This causes a 500 instead of logging the status of the bind. We should only display payload[:bind].status if it's available.
|
Rebased to get the Nokogiri pinning |
|
Thanks @dLobatog ! |
ekohl
added a commit
to ekohl/foreman
that referenced
this pull request
Jul 7, 2023
Fixes: c4bfd47 ("fixes theforeman#3725, theforeman#4167 - root password validations, remove default password")
ekohl
added a commit
to ekohl/foreman
that referenced
this pull request
Jul 11, 2023
Fixes: c4bfd47 ("fixes theforeman#3725, theforeman#4167 - root password validations, remove default password")
ekohl
added a commit
to ekohl/foreman
that referenced
this pull request
Oct 6, 2023
Fixes: c4bfd47 ("fixes theforeman#3725, theforeman#4167 - root password validations, remove default password")
Griffin-Sullivan
pushed a commit
to Griffin-Sullivan/foreman
that referenced
this pull request
Nov 21, 2023
Fixes: c4bfd47 ("fixes theforeman#3725, theforeman#4167 - root password validations, remove default password")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ldap logger tries to call payload[:bind].status but it might not be
defined if the bind goes wrong in some LDAP sources.
This causes a 500 instead of logging the status of the bind. We should
only display payload[:bind].status if it's available.