refs #18468 - move compute_resources JS to compute profile index #4282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CR JS should always be ready and loaded on the compute profile index, as the new attributes form is rendered into the existing page after the profile is created. Because the new attributes form is loaded via the two-pane #content replacement, the additional JavaScript tag specified in compute_profiles/show is not automatically loaded into the page. This fixes the issue for all compute resources, not only Libvirt. It also uses the `javascript` header to properly track the asset with Turbolinks so it's unloaded later.
|
@domcleal, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bastilian, @ares and @ShimShtein to be potential reviewers. |
ohadlevy
approved these changes
Feb 14, 2017
|
This makes the call to |
|
Thanks @domcleal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CR JS should always be ready and loaded on the compute profile
index, as the new attributes form is rendered into the existing page
after the profile is created.
Because the new attributes form is loaded via the two-pane #content
replacement, the additional JavaScript tag specified in
compute_profiles/show is not automatically loaded into the page.
This fixes the issue for all compute resources, not only Libvirt. It
also uses the
javascriptheader to properly track the asset withTurbolinks so it's unloaded later.