Fixes #18554 - skip collection_cache_lookup on authorized_for #4299
Conversation
|
@beav, thanks for your PR! By analyzing the history of the files in this pull request, we identified @amirfefer, @ohadlevy and @dLobatog to be potential reviewers. |
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
| test "disable cache when calling can?" do | ||
| as_user @user do | ||
| Authorizer.any_instance.expects(:can?).with(@permission, @domain1, false) | ||
| result = authorized_for({:permission => @permission, :auth_object => @domain1}) |
There was a problem hiding this comment.
Useless assignment to variable - result.
The call to `authorized_for` can take multiple seconds in some cases, leading to performance issues. This patch will bypass the cache lookup, resulting in similar times for admins and non-admins when viewing pages with lots of hosts.
|
Seems to have a significant error on REX jobs, merging.. Thanks @beav ! |
|
This patch does not make sense. The original problem was on one page that probably does not use authorizer object properly. After the cache is disabled, on every listing page (e.g. host index) we verify "view_hosts" permission on each table row for each subject separately. The cache normally loads all |
The call to
authorized_forcan take multiple seconds in some cases, leadingto performance issues.
This patch will bypass the cache lookup, resulting in similar times for admins
and non-admins when viewing pages with lots of hosts.