Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #19213 - use provision interface in foreman_url #4443

Merged

Conversation

iNecas
Copy link
Member

@iNecas iNecas commented Apr 7, 2017

Before this patch, we were using primary interface for checking on ftfp
proxy and its template feature. Provision interface is more appropriate
for this purposes.

@mention-bot
Copy link

@iNecas, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ares, @domcleal and @lzap to be potential reviewers.

Before this patch, we were using primary interface for checking on ftfp
proxy and its template feature. Provision interface is more appropriate
for this purposes.
@iNecas iNecas force-pushed the provision-interface-for-foreman-url branch from 567c372 to 63afdd2 Compare April 7, 2017 11:29
Copy link
Member

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean. Waiting for tests.

@lzap lzap merged commit 778d8bc into theforeman:develop Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants