fixes #19235 - vmware.rb : add Server 2016 support

[ricou84]

Add support for Windows 2016 server image based provisionning

[theforeman-bot]

There were the following issues with the commit message:

• 37fb6dd must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

---

This message was auto-generated by Foreman's prprocessor

[theforeman-bot]

Can an existing organization member please verify this patch?

[theforeman-bot]

Can an existing organization member please verify this patch?

[theforeman-bot]

Can an existing organization member please verify this patch?

[mention-bot]

@ricou84, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ohadlevy, @timogoebel and @mmoll to be potential reviewers.

[ricou84]

Seems not sufficient to support 2016

[mmoll]

please see the URL in line 191, the whole dataset would need an update, if there's a new vSphere version available

[ghost]

From the vSphere 6.5 GuestOSIdentifier Documentation the name should be "windows9Server64Guest" instead of "windows9srv-64". If i understand it right, just the label "Microsoft Windows Server Threshhold (64-bit)" should be replaced with "Microsoft Windows Server 2016 (64-bit)"

http://pubs.vmware.com/vsphere-65/index.jsp?topic=%2Fcom.vmware.wssdk.apiref.doc%2Fvim.vm.GuestOsDescriptor.GuestOsIdentifier.html

[mmoll]

Please either synchronize the whole list here, if that fixes the original issue or open another issue to synchronize the list and then continue to research the Win 2016 problem.

[ghost]

@mmoll i revised the whole list from the new vSphere 6.5 documentation.
see #4543

[mmoll]

GH-4617 got in, this can get closed.