New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #19947 - Fix creating bookmarks for global params #4661
Conversation
@xprazak2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @shlomizadok and @iNecas to be potential reviewers. |
Issues: #19947 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good @xprazak2 - could you add a functional test that creates a bookmark for global params using this controller? I plan to include this fix on 1.15.3 and patch release changes should come with tests
|
||
assert_redirected_to common_parameters_path | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra empty line detected at class body end.
I added a test |
Thanks @xprazak2 ! |
No description provided.