Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #20969 - Allow setting the rails version via settings.yaml.dist #4849

Merged
merged 1 commit into from Sep 20, 2017
Merged

Fixes #20969 - Allow setting the rails version via settings.yaml.dist #4849

merged 1 commit into from Sep 20, 2017

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 16, 2017

No description provided.

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 50e4c22 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@mention-bot
Copy link

@ekohl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @domcleal and @mmoll to be potential reviewers.

@ekohl ekohl mentioned this pull request Sep 16, 2017
Closed
@mmoll
Copy link
Contributor

mmoll commented Sep 17, 2017

Works for me 👍

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for 2032675 exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@ekohl ekohl changed the title Allow setting the rails version via settings.yaml.dist Fixes #20969 - Allow setting the rails version via settings.yaml.dist Sep 17, 2017
@ekohl
Copy link
Member Author

ekohl commented Sep 17, 2017

Rebased with a redmine issue.

dLobatog
dLobatog approved these changes Sep 20, 2017
View reviewed changes
Copy link
Member

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ekohl !

@dLobatog dLobatog merged commit c96801e into theforeman:develop Sep 20, 2017
@ekohl ekohl deleted the dist-rails-setting branch September 20, 2017 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dLobatog dLobatog dLobatog approved these changes

Assignees
No one assigned
Labels
Needs testing Not yet reviewed Waiting on contributor
Projects
None yet
Milestone
No milestone
5 participants
@ekohl @theforeman-bot @mention-bot @mmoll @dLobatog