Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #19050 - Use Rails 4.2 on Ruby 2.3 #4873

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Refs #19050 - Use Rails 4.2 on Ruby 2.3 #4873

merged 1 commit into from
Sep 27, 2017

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Sep 26, 2017

This unbreaks Ubuntu/xenial and Debian/stretch nightlies

@mmoll
Refs #19050 - Use Rails 4.2 on Ruby 2.3
96177d5 
This unbreaks Ubuntu/xenial and Debian/stretch nightlies
@theforeman-bot
Copy link
Member

Issues: #19050

dLobatog
dLobatog reviewed Sep 27, 2017
View reviewed changes
Copy link
Member

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmoll Does this not affect rpm nightly too?

@mmoll
Copy link
Contributor Author

mmoll commented Sep 27, 2017

AFAICT no, but I don't watch these closely

@mmoll
Copy link
Contributor Author

mmoll commented Sep 27, 2017

After seeing this again, nightly RPMs are using Ruby 2.2 now, so no change.

dLobatog
dLobatog approved these changes Sep 27, 2017
View reviewed changes
Copy link
Member

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmoll Thanks. Let's merge to allow debs to at least test our nightlies and then we can figure out what to do next if it affects RPM.

@dLobatog dLobatog merged commit 36e533a into theforeman:develop Sep 27, 2017
@mmoll mmoll deleted the ruby23 branch September 27, 2017 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dLobatog dLobatog dLobatog approved these changes

Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
3 participants
@mmoll @theforeman-bot @dLobatog