Fixes #21253 - fix latest events widget #4903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #21253 |
|
Looking at ee00829 that introduced it, the workaround was required because of older rails bug. @tbrisker covered it with tests which are green so I believe this is no longer necessary. I tested this also on older stack and it fixes the last event widget. Latest errata is still broken but that most likely needs to be fixed in katello, @akofink do you plan to look at that one too? The linked BZ mentions both widgets so after we merge this, it would be marked as fixed... Tested on
If noone objects, I'll merge this. |
|
Katello/katello#6995 and http://projects.theforeman.org/issues/21254 are for the errata widget. I just added 21254 to the BZ. Feel free to merge! Thanks! |
timogoebel
approved these changes
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.