Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #21815 - Do not search for permissions when db is empty #5036

Merged
merged 1 commit into from
Dec 14, 2017

Conversation

xprazak2
Copy link
Contributor

To be merged after we move to Rails 5.1 if the issue manifests itself.

@theforeman-bot
Copy link
Member

Issues: #21815

@xprazak2
Copy link
Contributor Author

This should be added to 1.17 milestone

@ares ares added this to the 1.17.0 milestone Dec 11, 2017
@ares
Copy link
Member

ares commented Dec 11, 2017

This should be added to 1.17 milestone

added, feel free to ping me if you need more PRs marked

@mmoll
Copy link
Contributor

mmoll commented Dec 11, 2017

This seems to happen also with Rails 5.0 with Katello...

please rebase.

@xprazak2
Copy link
Contributor Author

Rebased

@xprazak2
Copy link
Contributor Author

xprazak2 commented Dec 14, 2017

@ares , could you review? It should fix the katello failures for #4836

Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ohadlevy ohadlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@ares
Copy link
Member

ares commented Dec 14, 2017

Thanks @xprazak2, works fine here. Merging

@ares ares merged commit 9e00543 into theforeman:develop Dec 14, 2017
ohadlevy added a commit that referenced this pull request Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants