Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #22075 - move activateTooltips logic to react #5117

Merged
merged 1 commit into from Jan 2, 2018

Conversation

amirfefer
Copy link
Member

No description provided.

@amirfefer amirfefer changed the title move activateTooltips logic to react Fixes #22075 - move activateTooltips logic to react Dec 26, 2017
@sharvit
Copy link
Contributor

sharvit commented Dec 26, 2017

Nice @amirfefer!

What about tests and storybook?

@amirfefer
Copy link
Member Author

@sharvit I've extracted this component logic to a different npm package

Copy link
Contributor

@sharvit sharvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ohadlevy ohadlevy merged commit 0b77eb6 into theforeman:develop Jan 2, 2018
@ohadlevy
Copy link
Member

ohadlevy commented Jan 2, 2018

thanks @amirfefer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants