Fixes #22104 - adapt to Rails 5.1 change tracking #5133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #22104 |
tbrisker
reviewed
Jan 2, 2018
app/models/nic/interface.rb
Outdated
| @@ -57,13 +57,13 @@ def alias? | |||
| end | |||
|
|
|||
| def fqdn_changed? | |||
There was a problem hiding this comment.
Since these two methods are meant to mimic active record methods, should we also change them to the new naming?
There was a problem hiding this comment.
I thought its use were more spread over the code, but its indeed only in this file, so renaming was no problem 👍.
tbrisker
reviewed
Jan 3, 2018
app/models/host/base.rb
Outdated
| :hostname, :fqdn, :fqdn_changed?, | ||
| :fqdn_was, :shortname, | ||
| :hostname, :fqdn, :saved_change_to_fqdn?, | ||
| :fqdn_before_last_save, :shortname, |
There was a problem hiding this comment.
Do we actually use these anywhere? i think it may be leftovers from something, i couldn't find anywhere where these methods are called on a host
|
test failures unrelated, AFAICT. |
|
Setting to WOC, as GH-4987 exposed some more code paths with calls that need to get checked. |
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
No movement in GH-4987, so I'm kindly asking to proceed here... |
tbrisker
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.