[WIP] Fixes #22110 - update tests for minitest 5.11 #5138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #22110 |
|
seems like there's still an issue... minitest/minitest#729 |
|
Setting to WIP as there are a few changes required and/or changes to minitest will happen in the near future. |
mmoll
changed the title
mmoll
changed the title
|
This should be good to go now, after the Rails 5.1.6 update, which brought adjustments in Rails for the new minitest version. |
mmoll
changed the title
|
sigh, while the console output regarding the class names seems to be fixed, the result still is broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.