Fixes #22138 - fix tooltip triggering #5148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
amirfefer
changed the title
|
@tbrisker mind having a look? |
tbrisker
reviewed
Jan 3, 2018
| @@ -52,7 +52,7 @@ export function activateTooltips(elParam = 'body') { | |||
| el | |||
| .find('*[title]') | |||
| .not('*[rel]') | |||
| .tooltip({ container: 'body' }); | |||
| .tooltip({ container: 'body', trigger: 'hover' }); | |||
There was a problem hiding this comment.
why only on this and not on other tooltip activation methods? might make sense to clean up a bit an unify them
tbrisker
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
|
Thank you for your contribution, @amirfefer! This PR has been inactive for 6 months, closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltip is not removed after click and requires antoher click in order to remove it.
This may be annoying especially on dropdown / buttons etc...