Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

two small Rubocop fixes #5352

Merged
merged 2 commits into from Mar 26, 2018
Merged

two small Rubocop fixes #5352

merged 2 commits into from Mar 26, 2018

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Mar 22, 2018

No description provided.

@theforeman-bot
Copy link
Member

Issues: #22918

@mmoll
Copy link
Contributor Author

mmoll commented Mar 22, 2018

This is why I would prefer a Jenkins/travis/whatever job over hound :)

@mmoll
Copy link
Contributor Author

mmoll commented Mar 23, 2018

[test katello]

@mmoll
Copy link
Contributor Author

mmoll commented Mar 23, 2018

katello test failure unrelated 🙃

tbrisker
tbrisker approved these changes Mar 26, 2018
View reviewed changes
Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for some reason it wasn't linked from #15286.

@tbrisker tbrisker merged commit f170442 into theforeman:develop Mar 26, 2018
@tbrisker
Copy link
Member

Thanks @mmoll !

@mmoll mmoll deleted the rubocop branch March 26, 2018 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrisker tbrisker tbrisker approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
3 participants
@mmoll @theforeman-bot @tbrisker