Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Rubocop Fixes #5386

Merged
merged 7 commits into from Apr 4, 2018

Conversation

Projects
None yet
3 participants
@mmoll
Copy link
Member

mmoll commented Apr 2, 2018

No description provided.

@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Apr 2, 2018

Issues: #23080

@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Apr 2, 2018

There were the following issues with the commit message:

  • dc8acab must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Apr 2, 2018

There were the following issues with the commit message:

  • dc8acab must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@mmoll mmoll force-pushed the mmoll:rubocop_http_status branch from d7553ee to fc4ccaa Apr 2, 2018

@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Apr 2, 2018

There were the following issues with the commit message:

  • dc8acab must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@tbrisker

This comment has been minimized.

Copy link
Member

tbrisker commented Apr 2, 2018

go home @theforeman-bot, you're drunk

@tbrisker
Copy link
Member

tbrisker left a comment

Test failures unrelated. Thanks @mmoll !

@tbrisker tbrisker merged commit d0e1331 into theforeman:develop Apr 4, 2018

4 of 7 checks passed

foreman Build finished.
Details
katello Build finished.
Details
prprocessor Some commit messages have an incorrect style
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
upgrade Build finished.
Details

@mmoll mmoll deleted the mmoll:rubocop_http_status branch Apr 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.