Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Rubocop Fixes #5386

Merged
merged 7 commits into from
Apr 4, 2018
Merged

Some Rubocop Fixes #5386

merged 7 commits into from
Apr 4, 2018

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Apr 2, 2018

No description provided.

@theforeman-bot
Copy link
Member

Issues: #23080

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • dc8acab must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • dc8acab must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • dc8acab must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@tbrisker
Copy link
Member

tbrisker commented Apr 2, 2018

go home @theforeman-bot, you're drunk

tbrisker
tbrisker approved these changes Apr 4, 2018
View reviewed changes
Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures unrelated. Thanks @mmoll !

@tbrisker tbrisker merged commit d0e1331 into theforeman:develop Apr 4, 2018
@mmoll mmoll deleted the rubocop_http_status branch April 4, 2018 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrisker tbrisker tbrisker approved these changes

Assignees
No one assigned
Labels
Needs testing Waiting on contributor
Projects
None yet
Milestone
No milestone
3 participants
@mmoll @theforeman-bot @tbrisker