Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #23196 - Add default values for cores and socket in VM #5427

Merged
merged 2 commits into from
Apr 11, 2018
Merged

Fixes #23196 - Add default values for cores and socket in VM #5427

merged 2 commits into from
Apr 11, 2018

Conversation

shiramax
Copy link
Contributor

No description provided.

@theforeman-bot
Copy link
Member

Issues: #23196

@ekohl
Copy link
Member

ekohl commented Apr 10, 2018

(includes #5425)

There's a typo in your commit message/PR title.

@shiramax shiramax changed the title Fixes #23196 - Add defalut values for cores and socket in VM Fixes #23196 - Add default values for cores and socket in VM Apr 10, 2018
@shiramax
Copy link
Contributor Author

[test foreman]

dLobatog
dLobatog approved these changes Apr 11, 2018
View reviewed changes
Copy link
Member

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shiramax

@dLobatog dLobatog merged commit c0e00d6 into theforeman:develop Apr 11, 2018
@tbrisker tbrisker mentioned this pull request Apr 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dLobatog dLobatog dLobatog approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
4 participants
@shiramax @theforeman-bot @ekohl @dLobatog