Fixes puppetclasses search with pg database #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeah, i saw this is actually a rails bug, I guess we should call the uniq method instead? |
|
I don't quite get how this can be a rails bug when you specifically add both the DISTINCT yourself and the ORDER BY without any rails magic involved. |
The request is sorting the results on a field that isn't in the DISTINCT SELECT'ed columns and pg doesn't like it. Fixes #1607
|
merged - thanks! |
h0jeZvgoxFepBQ2C
pushed a commit
to h0jeZvgoxFepBQ2C/foreman
that referenced
this pull request
Jul 26, 2018
Fix for "..../lib/foreman/engine.rb:117:in `eof?': Input/output error - /dev/pts/n (Errno::EIO)" errors
cfouant
pushed a commit
to cfouant/foreman
that referenced
this pull request
Dec 18, 2018
Added simple os detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request is sorting the results on a field that isn't in the SELECT DISTINCT columns and pg doesn't like it.
Fixes #1607