fixes #2430 - undefined method gettext_translation_for_attribute_name

[lzap]

Also since compute resources are not model classes, I am adding back some
labels. Hopefully found them all, but I was only able to test libvirt.

[ohadlevy]

@lzap thanks! @grimme-atix-de any chance you can see if this solves your issue?

[MarcGrimme]

As the I "wrote" the patch the answer is yes ;-).

[ohadlevy]

@lzap hmm... are we missing credit then?

[MarcGrimme]

@ohadlevy don't bother. I don't care. I'm just happy if this goes through.

[lzap]

Yeah I re-wrote it as it was missing end of the line.

Re-pushed with correct author now. Sorry about that.

LZ

On Thu, Apr 25, 2013 at 06:46:37AM -0700, Marc Grimme wrote:

@ohadlevy don't bother. I don't care. I'm just happy if this goes through.

---

Reply to this email directly or view it on GitHub:
#551 (comment)

Later,

Lukas "lzap" Zapletal
irc: lzap #theforeman

[domcleal]

I'm happy with Marc's change, but I don't think we've got all of the labels added and strings extracted from the VM views. Here's a list of things I found through code inspection, please correct me @lzap if they're not applicable... I'm still learning this.

ec2:
1 <%= select_f f, :flavor_id, compute_resource.flavors, :id, :to_label %> # missing extracted label?
9 <%= selectable_f f, :availability_zone, compute_resource.zones, {:include_blank => _("No Preference")} %> # missing label?

libvirt:
2 <%= text_f f, :name, :disabled => !new if controller_name != "hosts" %> # missing label?
11 <%= field_set_tag "Network interfaces", :id => "network_interfaces", :title => _('Networks') do -%> # first param not extracted
24 <%= field_set_tag "Storage", :id => "storage_volumes", :title => _('Storage') do -%> # ditto

openstack:
2 <%= text_f f, :name, :disabled => !new if controller_name != "hosts" %> # missing label?
4 <%= select_f f, :tenant_id, compute_resource.tenants, :id, :name %> # ditto

ovirt:
2 <%= text_f f, :name if controller_name != "hosts" %> # missing label?

rackspace:
7

<%= select_f f, :image_id, images, :uuid, :name,
{ :include_blank => (images.empty? || images.size == 1) ? false : _('Please
Select an Image') }, { :disabled => images.empty? } %>

# label here? ec2 has _('UUID')

vmware:
2 <%= text_f f, :name, :disabled => !new if controller_name != "hosts" %> # missing label?
5 <%= selectable_f f, :cluster, compute_resource.clusters, { }, :class => "span2", :disabled => !new %> # ditto
37 <%= checkbox_f f, :start, { :checked => (checked == '1'), :help_inline => _("Power ON this machine") } if new and controller_name == 'hosts' %> # ditto

vmware/_volume.html.erb:
3 <%= text_f f, :name, :class => "input-mini", :label => "Name" %> # not extracted

[lzap]

Tomorrow I am going to try Fog.mock! get working on my instance to actually test all the screens. I think I really need to see them all...

[lzap]

Ok I am only providing the oneline fix, I am moving out gettext extraction of non-model based views into different branch - we do not want to be blocked by this one. Thanks to Marc for the patch.

[domcleal]

Merged as 17aecd7 for Foreman 1.2. Thanks for the contribution @grimme-atix-de!