Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #23576 - Fix the 'webpacked_plugins_js_for' helper #5552

Merged
merged 1 commit into from
May 16, 2018
Merged

Fixes #23576 - Fix the 'webpacked_plugins_js_for' helper #5552

merged 1 commit into from
May 16, 2018

Conversation

xprazak2
Copy link
Contributor

For some reason, using symbol does not work any more. Turning it into a string seems to fix it.

@theforeman-bot
Copy link
Member

Issues: #23576

@ares
Copy link
Member

ares commented May 15, 2018

@dLobatog is this the thing you observed last week? could you take a look pls?

@ares ares mentioned this pull request May 16, 2018
Closed
ares
ares approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@ares ares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xprazak2, no point in delaying this. I know at least foreman_ansible was hit by this so I think it would make sense to cherry-pick it into 1.18-stable. I'll open a PR and set the milestone and redmine issue accordingly.

@ares ares added this to the 1.18.0 milestone May 16, 2018
@ares ares merged commit 54e6af1 into theforeman:develop May 16, 2018
@ares
Copy link
Member

ares commented May 16, 2018

here's the CP PR #5572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ares ares ares approved these changes

Assignees
No one assigned
Labels
Ready to merge
Projects
None yet
Milestone
1.18.0
3 participants
@xprazak2 @theforeman-bot @ares