Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23776 - Remove deprecations for 1.18 #5639

Merged
merged 1 commit into from Jun 3, 2018
Merged

Fixes #23776 - Remove deprecations for 1.18 #5639

merged 1 commit into from Jun 3, 2018

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Jun 1, 2018

No description provided.

@theforeman-bot
Copy link
Member

Issues: #23776

@mmoll
Copy link
Contributor Author

mmoll commented Jun 1, 2018

I didn't see that GH-5638 was not against develop, cherry-pick to it, also.

Copy link
Contributor

@xprazak2 xprazak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xprazak2 xprazak2 merged commit a08192f into theforeman:develop Jun 3, 2018
@timogoebel
Copy link
Member

@mmoll, @xprazak2: I believe this should have been removed in 1.20, not 1.18. Can we please add this again?
notice() was deprecated in 1.18, so we should keep it two more versions and not remove it in 1.18.

@mmoll
Copy link
Contributor Author

mmoll commented Jun 5, 2018

@timogoebel It was marked for removal with 1.18, but yes, the 1.18 note was added in cf94f62, which is only part of 1.18.

I'll open a PR to correct this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants