Refs #21580 - require rbvmomi #5659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compute resource for VMware was using rbvmomi classes wihout explicitly requiring rbvmomi. That can cause issues in tests.
|
Issues: #21580 |
|
@timogoebel would you mind taking a look? |
dLobatog
approved these changes
Jun 7, 2018
There was a problem hiding this comment.
Thanks @tstrachota - I'm going to go with merging so our test_develop can go green again. I haven't tested but I doubt the require + rescue is a problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compute resource for VMware was using
rbvmomiclasses wihout explicitly requiringrbvmomi. That can cause "NameError: uninitialized constant RbVmomi" errors in tests (https://ci.theforeman.org/job/puppetdb_foreman-pull-request/11/database=mysql,label=fast,ruby=2.4/testReport/junit/(root)/Foreman__Model__VmwareTest___normalize_vm_attrs/).rbvmomiis dependency offog-vspherethat we require when foreman is installed with WMware support. We have that already packaged.