Fix loading settings in production #574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks quite sensible, although I'm surprised the settings aren't properly loaded in Production... |
|
@iNecas needs a rebase ;) |
The Setting subclasses are not preloaded in initialization phase in production. Also (if Setting.first rescue (false)) is not satisfied when the settings are not set yet. Using table_exists? instead. Also, define constants before audited So that the constants are available even when not migrated yet.
|
@GregSutcliffe rebased |
|
@ohadlevy review? |
|
This fixes an error with the debian nightlies where the settings table is not properly initialised. I'd like to see this merged quickly. |
|
merged - thanks! |
h0jeZvgoxFepBQ2C
pushed a commit
to h0jeZvgoxFepBQ2C/foreman
that referenced
this pull request
Jul 26, 2018
Fixes theforeman#574. Better late than never.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Setting subclasses are not preloaded in initialization phase in
production.
Also (if Setting.first rescue (false)) is not satisfied when the settings are
not set yet. Using table_exists? instead.