Fixes #24091 - add pf empty state design to hostsgroup #5743
Conversation
|
Issues: #23920 |
|
I've noticed the same issue with Edit: a regression fix opened here #5748 |
| </div> | ||
| <h1><%= _('Host Groups') %></h1> | ||
| <p><%= _("Host Groups allow hosts with common configuration to be defined and grouped together. | ||
| in some ways similar to an inherited node declaration, in that it is a high level grouping of classes that can be named and treated as a unit. |
There was a problem hiding this comment.
This sentence doesn't make much sense like it is, did something get removed by mistake? cc @GregSutcliffe if you can think of a good 'welcome' message for host groups that'd be helpful 😄
There was a problem hiding this comment.
My suggestion: Hosts can be grouped together to share common configuration. Nested groups will inherit from their parent(s).
amirfefer
changed the title
|
whats the status of this PR? thanks :) |
|
@amirfefer bump?? |
|
rebased + updated |
| <div class="blank-slate-pf-main-action"> | ||
| <%= new_link(_("Create Host Group"), :class => 'btn-lg') %> | ||
| </div> | ||
| </div> |
| </div> | ||
| <h1><%= _('Host Groups') %></h1> | ||
| <p><%= _("Host Groups allow hosts with common configuration to be defined and grouped together. | ||
| Hosts can be grouped together to share common configuration. Nested groups will inherit from their parent(s). |
There was a problem hiding this comment.
Host Groups allow hosts with common configuration to be defined and grouped together. Hosts can be grouped together to share common configuration.
These 2 sentences are almost identical. I would keep just one of them.
|
@amirfefer, any progress on this? |
|
ping @amirfefer, this one looks almost ready to merge and just needs a minor change and rebase, do you want to do that or shall we close it? |
|
@tbrisker Thanks for the reminder, done :) |
before:
after:
