Fixes #24072 - Fix free IP auto suggest for hostgroup with compute resource #5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, the 'Virtual Machine' tab was giving: 'mybox' not found on 'libvirt (Libvirt)' 'mybox' could be deleted or 'libvirt (Libvirt)' is not responding. (cherry picked from commit 641ef42)
When compute resource is set via compute profile, we're not sending it via the form (as it's disabled). Therefore, we need to search for in via hostgroup. (cherry picked from commit cbe40e3)
In theforeman#5790, we added an option to set the compute resource via hostgroup. There was one thing missed though: the freeip not getting assigned automagically, when the compute resource was selected this way. After this change, we make sure to check for the ip addresses (and other potential subnet related refreshes) after the hostgroup is selected, in case the interfaces were populated during the hostgroup change. (cherry picked from commit dc31392)
|
Issues: #24072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.