Fixes #23918 - Find correct scope when updating taxonomy #5768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #23918 |
dLobatog
suggested changes
Jul 5, 2018
| @@ -88,7 +88,7 @@ def destroy | |||
|
|
|||
| # overriding public FindCommon#resource_scope to scope only to user's taxonomies | |||
| def resource_scope(*args) | |||
| super.send("my_#{taxonomies_plural}") | |||
| @resource_scope = scope_for(resource_class, args).send("my_#{taxonomies_plural}") | |||
There was a problem hiding this comment.
I do not see a reason why there is a ||= in the first place, what if the cached data is stale?
There was a problem hiding this comment.
||= seems to work here as well, so I made the change.
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
I added test and changed |
dLobatog
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resource_scope caches the scope, on update the
@resource_scopeis[](no idea how that happens), butscope_forfetches the correct scope.