Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #21778 - ignore tax scope when displaying filters #5834

Merged
merged 1 commit into from
Jul 15, 2018
Merged

Fixes #21778 - ignore tax scope when displaying filters #5834

merged 1 commit into from
Jul 15, 2018

Conversation

ares
Copy link
Member

@ares ares commented Jul 13, 2018

Steps to Reproduce:

  1. Login with admin
  2. Navigate to Administer -> Roles
  3. Create role cloning Organization admin role
  4. Create user providing location, organization and created role
  5. Login with created user
  6. Create test role
  7. Edit role to add new filter
  8. Click on role to see added filters.

This is caused by the fact, filters are hidden by Taxonomix but in fact these are global resources. They are taxable because of authorization.

@theforeman-bot
Copy link
Member

Issues: #21778

tbrisker
tbrisker approved these changes Jul 15, 2018
View reviewed changes
Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests, works well, thanks @ares !

@tbrisker tbrisker merged commit 8c5fcff into theforeman:develop Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrisker tbrisker tbrisker approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
3 participants
@ares @theforeman-bot @tbrisker