Refs #24281 - Refactor class methods of create and create! #5847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #24281 |
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
theforeman-bot
added
Waiting on contributor
Needs testing
Not yet reviewed
and removed
Waiting on contributor
labels
dLobatog
suggested changes
Jul 18, 2018
app/models/setting.rb
Outdated
| else | ||
| create_existing(s, opts) | ||
| s = Setting.find_by_name(opts[:name].to_s) | ||
| if s |
There was a problem hiding this comment.
nitpick, return create_existing(s, opts) if s
app/models/setting.rb
Outdated
| @@ -198,28 +198,29 @@ def parse_string_value(val) | |||
| true | |||
| end | |||
|
|
|||
| def self.create(opts) | |||
| # in order to avoid code duplication, this method was introduced | |||
| def self.create_find_by_name(opts, &block) | |||
There was a problem hiding this comment.
You may remove the &block, implicit is way faster - you may get some background here ruby/ruby#1240
There was a problem hiding this comment.
keep on forgetting that :( thanks
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
@dLobatog what do you think of this now? |
dLobatog
approved these changes
Jul 19, 2018
|
Thanks @ik5 ! |
|
@ik5 please don't use Refs in git commit message, it only links the PR in redmine but does not close the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.