Fixes #24697 - Don't remove permissions from default role #5999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default role may have permissions added by users. They should remain without removal. If a seeded permissions needs removal from the default role, it should be explicitly removed in a migration. Additionally, attempting to remove permissions with filters from a role led to a failure due to an incorrect search parameter which has now been fixed. (cherry picked from commit ada7d6e)
houndci-bot
reviewed
Aug 28, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `S...
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) The `Performance/HashEachMethods` cop has been removed since it no longer provides performance benefits in modern rubies.
|
Issues: #24697 |
tbrisker
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default role may have permissions added by users. They should remain
without removal. If a seeded permissions needs removal from the default
role, it should be explicitly removed in a migration.
Additionally, attempting to remove permissions with filters from a role
led to a failure due to an incorrect search parameter which has now been
fixed.
(cherry picked from commit ada7d6e)