Fixes #24874 - update secure_headers to 6.x #6055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #24874 |
This was referenced Sep 10, 2018
|
I didn't find any places in our code that are mentioned in the docs for breaking changes of 6.x and an update of my prod instance didn't seem to introduce any ill effects... |
ekohl
approved these changes
Sep 11, 2018
|
@mmoll while i'm fine with this, i wonder if we still need it at all? iirc rails 5.2 already includes options for setting most if not all of the headers we use. |
|
I'd vote for getting this in now to have a good gut feeling for the time being. 😏 I did subscribe to github/secure_headers#375 and opened https://projects.theforeman.org/issues/24934 in order to check if the current config we use is on Rails 5.2 standards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.